Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for ruff formatter #4645

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

crimsonknave
Copy link
Contributor

Adds support for the new ruff formatter as requested in #4609. I took the existing ruff fixer and made a version that runs the format command. That way the user can opt into either or both of them.

This is built on top of #4347 and #4393 and contains only a few tweaks (the version checking was removed because the formatter was added well after the version in question).

@sbv-csis
Copy link

Running this as my ALE now. My project just deprecated black infavor of ruff format 👍

w0rp
w0rp previously approved these changes Nov 5, 2023
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks fine to me.

Cheers! 🍻

@w0rp w0rp enabled auto-merge (squash) November 5, 2023 18:21
@w0rp
Copy link
Member

w0rp commented Nov 5, 2023

Have a look at the CI issues.

auto-merge was automatically disabled November 13, 2023 17:39

Head branch was pushed to by a user without write access

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! 🍻

@w0rp w0rp merged commit 5cddc4c into dense-analysis:master Nov 16, 2023
13 checks passed
@crimsonknave crimsonknave deleted the add_ruff_format branch November 17, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants