Ruff use json-lines output format #4656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the json-lines output format allows for setting of the end_line, end_col and code field of the handle output. Additionally, the first letter of the code is used to determine the type field.
w0rp
previously approved these changes
Dec 10, 2023
There was a problem hiding this comment.
I check other linters more carefully for changes to arguments, but this is probably good and I'll take this. I don't yet consider ruff to be stable enough to be used in my day job or for Dense Analysis code, but I'm looking forward to the future where after a few more bug fixes it can completely replace flake8 and others for me, because the improvements to execution time are great.
Cheers! 🍻
w0rp
reviewed
Dec 10, 2023
w0rp
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the json-lines output format allows for setting of the end_line, end_col and code field of the handle output.
Additionally, the first letter of the code is used to determine the type field.