Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full support for biome #4705

Merged
merged 2 commits into from
Feb 24, 2024
Merged

Add full support for biome #4705

merged 2 commits into from
Feb 24, 2024

Conversation

toxeus
Copy link
Contributor

@toxeus toxeus commented Jan 8, 2024

ALE currently has received very limited support for biome. Neither its linting capabilities nor its auto-formatter are exposed to ALE. Instead, the fixer implements a "lint-auto-fix" for a few lints that are auto-fixable by biome which is inconsistent with the behavior of other fixers that implement auto-format.

Closes #3280

@toxeus toxeus force-pushed the master branch 4 times, most recently from a01ba32 to 1f50b1d Compare January 9, 2024 23:33
@toxeus toxeus changed the title Add support for biome Add full support for biome Jan 14, 2024
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@hsanson hsanson merged commit 9cc8383 into dense-analysis:master Feb 24, 2024
7 checks passed
\ . ale#Pad(l:options)
\ . ' %t',
\ 'read_temporary_file': 1,
\ 'command': '%e format'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for commenting on an already merged PR, but to me it seems like %e is not substituted with the executable when I run this. Switching to use l:executable directly works fine. Is %e supposed to work in this context?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lanker I created a PR for this issue. #4733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Rome
4 participants