Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dart analysis_server command #4761

Merged
merged 4 commits into from
May 9, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ale_linters/dart/analysis_server.vim
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
" Author: Nelson Yeung <[email protected]>
" Description: Check Dart files with dart analysis server LSP

call ale#Set('dart_analysis_server_enable_language_server', 1)
call ale#Set('dart_analysis_server_executable', 'dart')

function! ale_linters#dart#analysis_server#GetProjectRoot(buffer) abort
Expand All @@ -12,12 +13,19 @@ function! ale_linters#dart#analysis_server#GetProjectRoot(buffer) abort
endfunction

function! ale_linters#dart#analysis_server#GetCommand(buffer) abort
let l:language_server = ale#Var(a:buffer, 'dart_analysis_server_enable_language_server')
let l:executable = ale#Var(a:buffer, 'dart_analysis_server_executable')
let l:dart = resolve(exepath(l:executable))

return '%e '
let l:output = '%e '
\ . fnamemodify(l:dart, ':h') . '/snapshots/analysis_server.dart.snapshot'
\ . ' --lsp'

" Enable new language-server command
if l:language_server == 1
let l:output = '%e language-server --protocol=lsp'
endif

return l:output
endfunction

call ale#linter#Define('dart', {
Expand Down
11 changes: 11 additions & 0 deletions doc/ale-dart.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,17 @@ g:ale_dart_analysis_server_executable *g:ale_dart_analysis_server_executable*
This variable can be set to change the path of dart.


g:ale_dart_analysis_server_enable_language_server
*g:ale_dart_analysis_server_enable_language_server*
*b:ale_dart_analysis_server_enable_language_server*
Type: |Number|
Default: `1`

When set to `1`, ALE will use the new `dart language-server` command to
launch the language server. When set to `0`, ALE will use the original
`./snapshots/analysis_server.dart.snapshot --lsp` command.

hsanson marked this conversation as resolved.
Show resolved Hide resolved

===============================================================================
dart-analyze *ale-dart-analyze*

Expand Down
8 changes: 7 additions & 1 deletion test/linter/test_dart_analysis_server.vader
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,16 @@ After:

Execute(The default command should be correct):
AssertLinter 'dart', ale#Escape('dart')
\ . ' ./snapshots/analysis_server.dart.snapshot --lsp'
\ . ' language-server --protocol=lsp'

Execute(The executable should be configurable):
let g:ale_dart_analysis_server_executable = 'foobar'

AssertLinter 'foobar', ale#Escape('foobar')
\ . ' language-server --protocol=lsp'

Execute(Should be able to disable new language-server command):
let g:ale_dart_analysis_server_enable_language_server = 0

AssertLinter 'dart', ale#Escape('dart')
\ . ' ./snapshots/analysis_server.dart.snapshot --lsp'