Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC Implement Alembic #2867

Closed
wants to merge 6 commits into from
Closed

Conversation

tyler-spangler6
Copy link
Contributor

What was the problem?

This PR sets up alembic for use in cc database migrations.
Associated tickets or Slack threads:

  • #?

How does this fix it?1

This establishes the setup of alembic. Will require some work to have it only edit the domain-cc schema.

How to test this PR

  • Step 1
  • Step 22

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page.

  2. To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline.

Copy link

github-actions bot commented Apr 17, 2024

Test Results

109 tests  ±0   109 ✅ ±0   35s ⏱️ -1s
 33 suites ±0     0 💤 ±0 
 33 files   ±0     0 ❌ ±0 

Results for commit 14e163f. ± Comparison against base commit b211f2d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 17, 2024

JaCoCo Test Coverage

Overall Project 65.19%

There is no coverage information present for the Files changed


1. Update the data models in `abd-vro/domain-cc/cc-app/alembic/db_models.py`
2. From `cc-app` directory run `alembic revision --autogenerate -m <add note about changes>`
3. Run `alembic upgrade head` to apply migrations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to update my database and create a new migration based on these instructions e.g. adding va.gov claim id

These were created in the public schema for my local machine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants