Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim Tracker: Create application #3425

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Conversation

dfitchett
Copy link
Contributor

@dfitchett dfitchett commented Sep 4, 2024

Summary

Creates the new

Associated tickets or Slack threads:

How does this fix it?1

  • creates the base skeleton of the claim tracker application
  • creates the rest endpoint to add claims to track
  • creates the database table for claims.tracked_claims
  • sets up code quality checks using ruff, isort, mypy, and runs black formatting
  • creates unit tests for health check endpoint and track claim endpoint

How to test this PR

  • download branch and cd to root dir
  • run ./gradlew :domain-bie-events:svc-claim-tracker:check
  • run ./gradlew clean docker
  • run COMPOSE_PROFILES="platform" ./gradlew :dockerComposeUp
  • run COMPOSE_PROFILES="all" ./gradlew :domain-bie-events:dockerComposeUp
  • send curl:
curl -L 'http://localhost:8150/track/v1/claim' -H 'Content-Type: application/json' -d '{
    "claim_id": 123,
    "established_at": "2024-01-01T00:00:00Z",
    "feature_name":"feature",
    "feature_enabled":true
}'

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page.

@dfitchett dfitchett requested a review from a team as a code owner September 4, 2024 21:47
Copy link

github-actions bot commented Sep 4, 2024

Test Results

136 tests  ±0   136 ✅ ±0   18s ⏱️ ±0s
 39 suites ±0     0 💤 ±0 
 39 files   ±0     0 ❌ ±0 

Results for commit 7438f27. ± Comparison against base commit da28b0b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 4, 2024

JaCoCo Test Coverage

Overall Project 73.12%

There is no coverage information present for the Files changed

@dfitchett dfitchett linked an issue Sep 4, 2024 that may be closed by this pull request
4 tasks
@dfitchett dfitchett requested review from CorySohrakoffUSDS and removed request for Ponnia-M September 5, 2024 16:47
Copy link
Contributor

@lisac lisac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, Derek! some minor comments, none should block the merge.

domain-bie-events/.pre-commit-config.yaml Show resolved Hide resolved
domain-bie-events/svc-claim-tracker/README.md Outdated Show resolved Hide resolved
domain-bie-events/svc-claim-tracker/src/app/api.py Outdated Show resolved Hide resolved
@Ponnia-M
Copy link
Contributor

Ponnia-M commented Oct 8, 2024

@dfitchett What was the outcome of you testing these changes locally?

@Ponnia-M Ponnia-M self-requested a review October 8, 2024 18:58
@dfitchett
Copy link
Contributor Author

dfitchett commented Oct 8, 2024

@dfitchett What was the outcome of you testing these changes locally?

@Ponnia-M It runs no problems. I'll update the directions above.

Copy link
Contributor

@Ponnia-M Ponnia-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this branch locally and it was successful. Great work!

@dfitchett dfitchett merged commit d6f662a into develop Oct 8, 2024
17 checks passed
@dfitchett dfitchett deleted the dfitchett/claim-tracker-init branch October 8, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Claim Tracker: Implement REST endpoint to accept request to track claim
5 participants