Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: upgrade to poetry ^1.0.0 #1739

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Conversation

tommilligan
Copy link
Contributor

@tommilligan tommilligan commented Mar 15, 2020

Upgrades Dependabot to using Poetry v1. This is backwards compatible with existing lockfiles, while supporting the new lockfile features introduced in v1.

This is based on #1710, but also:

  • upgrades python/helpers test fixtures
  • changes tests fixed by the upgrade from pending -> it

@ulgens
Copy link
Contributor

ulgens commented Mar 22, 2020

@jurre Heyo 👋 Can you please point out someone to look at this PR? 🙂 The issue with poetry became slightly embrassing imo, it's very easy to fix but waiting there for last 4 months.

@ulgens
Copy link
Contributor

ulgens commented Mar 22, 2020

Hi @tommilligan, this PR doesn't close #1556 and i'm not sure about #1621 . The issue in #1556 wasn't using old version of Poetry, it was Dependabot doesn't respect given version value in pyproject.toml. I started to think, if single version upgrade for Poetry takes months, multiple version support is impossible in foreseeable future. If that one gets merged, i'll close #1556 myself but again, this PR doesn't fix it.

Note: #1556 is misunderstood by a lot of people, but i'm kinda okay with it because it's raised some awareness about outdated version.

@ulgens
Copy link
Contributor

ulgens commented Mar 22, 2020

Shameless plug, i just saw #1621 (comment)

I'm afraid I don't work on Dependabot anymore (I'm focussed on other security products at GitHub), but @feelepxyz and the team should be able to help!

@feelepxyz ping 🙂

@tommilligan
Copy link
Contributor Author

@ulgens I've removed the Closes issue tags so they can be discussed and closed separately.

Copy link
Contributor

@feelepxyz feelepxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jurre
Copy link
Member

jurre commented Mar 24, 2020

Thanks @tommilligan, this looks good to me 👍

@jurre jurre merged commit 3fc96b9 into dependabot:master Mar 24, 2020
@tommilligan
Copy link
Contributor Author

You're welcome - thanks for making a great tool for so many languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants