Update maven test output #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amazimbe
force-pushed
the
amazimbe/update-maven-test
branch
from
f38bf94
to
a160154
Compare
amazimbe
changed the title
amazimbe
force-pushed
the
amazimbe/update-maven-test
branch
from
a160154
to
7f3620d
Compare
kbukum1
reviewed
Sep 11, 2024
| @@ -212,11 +212,11 @@ output: | |||
| groups: [] | |||
| metadata: | |||
| packaging_type: pom | |||
| requirement: 1.5.12.RELEASE | |||
| requirement: 1.5.11.RELEASE | |||
There was a problem hiding this comment.
It is not something big since the pattern same, just wanted to check if there is a reason we didn't use the same version 1.5.12.RELEASE
kbukum1
reviewed
Sep 11, 2024
| @@ -4,7 +4,7 @@ name: Smoke | |||
| on: # yamllint disable-line rule:truthy | |||
| workflow_dispatch: | |||
| pull_request: | |||
| branches: ["main"] | |||
| branches: ["amazimbe/use-new-maven-version"] | |||
There was a problem hiding this comment.
Please let's not forget to switch back that before the merging.
|
Closing in favour of #228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue: #226
The updated test started failing after this change: dependabot/dependabot-core#10558 and this PR updates the contents of the output section so that the tests pass again.