Add colorSpaceName to Solarized themes #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I didn't know it was possible to set a colour space, that's pretty interesting. So this forces TM to always use SRGB? |
|
Indeed. It's a fairly recent addition for themes (textmate/textmate@d70ccc7) that explicitly sets the color space to sRGB. Otherwise, Apple Generic RGB is used by default. More details from Alan here: aziz/tmTheme-Editor#15 |
|
👍 I say merge! :) |
|
Another vote for merging, it fixes color discrepancies (esp bgcolor) between Solarized dark in iTerm/vim, etc and TM2 (#33). |
This was referenced Feb 20, 2014
|
👍 The Solarized palette is listed in sRGB on the homepage, so it appears lighter in TextMate. Adding this key should fix it (related post about the color space issue). |
deplorableword
added a commit
that referenced
this pull request
Apr 1, 2015
Add colorSpaceName to Solarized themes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #33 in TM2.