Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: actually pass sort_filter to DoPaginatedGet in GetComputersInventory #491

Merged
merged 1 commit into from
Sep 7, 2024
Merged

fix: actually pass sort_filter to DoPaginatedGet in GetComputersInventory #491

merged 1 commit into from
Sep 7, 2024

Conversation

jsifuentes
Copy link
Contributor

@jsifuentes jsifuentes commented Sep 7, 2024 •
edited
Loading

Change

The sort_filter parameter was not passed to DoPaginatedGet, so it did nothing.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@jsifuentes jsifuentes marked this pull request as ready for review September 7, 2024 00:39
@ShocOne ShocOne merged commit c147733 into deploymenttheory:main Sep 7, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShocOne ShocOne ShocOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsifuentes @ShocOne