Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to disable recursive mode excepts "chmod" mode #1822

Closed
janreges opened this issue Mar 30, 2019 · 2 comments
Closed

Unable to disable recursive mode excepts "chmod" mode #1822

janreges opened this issue Mar 30, 2019 · 2 comments

Comments

@janreges
Copy link
Contributor

janreges commented Mar 30, 2019 •
edited
Loading

Hi,

Thank you for Deployer - we use it few years and it's great tool! 👍

We encountered one problem. Deployer contains writable_chmod_recursive which is handled only by mode "chmod" and it is not suitable for us.

All another modes are forced to be recursive without option to disable recursive mode.

Default mode setfacl is optimal, but when project contains a lot of files, task deploy:writable then runs long minutes due to recursive mode, which is unnecessary :-(

Optimal would be one common parameter writable_recursive (default: true) used by all modes. Due to backward compatibility, writable_chmod_recursive would have priority in chmod mode.

What do you think?

Thank you.
@antonmedv
Copy link
Member

I think this is better. Can you create pull request?

janreges added a commit to janreges/deployer that referenced this issue Mar 31, 2019
@janreges
Added writable_recursive option (default: true) used in all writabl…
6529625 
…e modes (chmod, chown, chgrp, acl) (deployphp#1822)
@janreges janreges mentioned this issue Mar 31, 2019
Merged
@janreges
Copy link
Contributor Author

@antonmedv PR is ready with updated CHANGELOG.md. Thank you for merge :-)

antonmedv pushed a commit that referenced this issue Mar 31, 2019
@janreges @antonmedv
Added writable_recursive option (default: true) used in all writabl…
c37f599 
…e modes (chmod, chown, chgrp, acl) (#1823)

* Added `writable_recursive` option (default: true) used in all writable modes (chmod, chown, chgrp, acl) (#1822)

* Update CHANGELOG.md
@janreges janreges changed the title Unable to disable recursive mode excepts setfacl mode Unable to disable recursive mode excepts "chmod" mode Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antonmedv @janreges