ssh keyscan with username

[antonmedv]

Discussed in #2666

^{Originally posted by underdpt September 23, 2021}
Hello,

With v7.0.0-beta25, this setup:

set('repository', 'ssh://[email protected]:2233/folder/project.git');
set('ssh_multiplexing', PHP_OS_FAMILY === 'Windows' ? false : true);
set('default_timeout', null);

host('my.server.host')
    ->set('labels', ['stage' => 'production'])
    ->set('branch', 'master')
    ->set('remote_user', 'mainsip')
    ->set('port', 2223)
    ->set('deploy_path', '/var/www/project');

produces this error:

info deploying master
task deploy:setup
task deploy:lock
task deploy:release
task deploy:update_code
[my.server.host]  error  in update_code.php on line 54:
[my.server.host] run ssh-keyscan -p 2233 -H [email protected] >> ~/.ssh/known_hosts
[my.server.host] err getaddrinfo [email protected]: Name or service not known
[my.server.host] err getaddrinfo [email protected]: Name or service not known
[my.server.host] err getaddrinfo [email protected]: Name or service not known
[my.server.host] err getaddrinfo [email protected]: Name or service not known
[my.server.host] err getaddrinfo [email protected]: Name or service not known
[my.server.host] exit code 1 (General error)

I think the error might be that the hostname is including the user part git@... for the ssh-keyscan command.

This works with v7.0.0-beta24

[Sander-Toonen]

deployer/recipe/deploy/update_code.php

Line 48 in 363f7ed

if (preg_match('/(?:@|\/\/)([^\/:]+)(?:\:(\d{1,5}))?/', $repository, $matches)) {

This regex is too naïve. It will also fail when the repository is pulled over http, in which case key-scanning makes no sense. I would suggest using parse_url. Then only do the keyscanning when the scheme equals "ssh" and use the "host" component. Any thoughts on that?

[antonmedv]

Can you create a PR with a fix?

[Sander-Toonen]

Coming up...

[Sander-Toonen]

Could you please release a new beta? This issue is breaking quite some pipelines and downgrading is not possible due to #2592.

[antonmedv]

Released beta.26