Change output of errors for native ssh (#1012) #1051
Conversation
pluseg
commented
Feb 24, 2017
pluseg
commented
| Q | A |
|---|---|
| Bug fix? | No |
| New feature? | Yes |
| BC breaks? | No |
| Deprecations? | No |
| Fixed tickets | #1012 |
| @@ -18,8 +20,6 @@ | |||
| - Fixed possibility to use PEM files with Native SSH | |||
| - Fixed old releases not being cleaned up when keep_releases reduced by more than half. | |||
|
|
|||
| ### Changed | |||
| - Add task queue:restart for Laravel recipe [#1007](https://github.com/deployphp/deployer/pull/1007) | |||
There was a problem hiding this comment.
Just combined with same section above.
| @@ -49,7 +50,6 @@ public function run($command) | |||
| $serverConfig = $this->getConfiguration(); | |||
| $sshOptions = [ | |||
| '-A', | |||
| '-q', | |||
There was a problem hiding this comment.
@Elfet Is there a real reason of adding "-q" option? Without it ssh returns 255 status code (Unknown error) and empty output.
There was a problem hiding this comment.
Don't know 🙄 It came from PR.
src/Server/Remote/NativeSsh.php
Outdated
| ->setIdleTimeout(null) | ||
| ->mustRun(); | ||
| } catch (ProcessFailedException $exception) { | ||
| $errorMessage = \Deployer\isVerbose() ? $exception->getMessage() : $process->getErrorOutput(); |
There was a problem hiding this comment.
Why in verbose mode using message and otherwise error output?
There was a problem hiding this comment.
@Elfet Error output returns only error string like "invalid credentials" and an exception message has current look with full broken command, current directory, error string, etc. I think that common user needs only concise error string.
There was a problem hiding this comment.
@Elfet I used it but then noted that there is one usage of Verbose in the file. Okay, I'll update the PR.
