add magento2 base recipe #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
unailopez16
commented
Nov 28, 2016
unailopez16
commented
| Q | A |
|---|---|
| Bug fix? | No |
| New feature? | Yes |
| BC breaks? | No |
| Deprecations? | No |
| Fixed tickets | #713 |
|
Reviewed this in #713 |
antonmedv
reviewed
Dec 23, 2016
| 'magento:maintenance:disable' | ||
| ]); | ||
|
|
||
| after('deploy:clear_paths', 'deploy:magento'); |
There was a problem hiding this comment.
It's better to have only one deploy task in standard recipes.
| set('clear_paths', ['var/generation/*', 'var/cache/*']); | ||
|
|
||
| // Tasks | ||
| desc('Enable all modules'); task('magento:enable', function () { |
| task('magento:upgrade:db', function () { | ||
| run("{{bin/php}} {{release_path}}/bin/magento setup:db-schema:upgrade"); | ||
| run("{{bin/php}} {{release_path}}/bin/magento setup:db-data:upgrade"); | ||
| writeln("Database upgraded"); |
There was a problem hiding this comment.
No need to writeln, dep will inform user itself.
| desc('Flush Magento Cache'); | ||
| task('magento:cache:flush', function () { | ||
| run("{{bin/php}} {{release_path}}/bin/magento cache:flush"); | ||
| writeln("Magento cache flushed"); |
There was a problem hiding this comment.
Same here, deployer will print:
✔︎ Executing task magento:cache:flush
|
Thanks for this, was looking for something like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.