Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 본인 프로필 페이지 > 친구 찾기 동선 추가 #438

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

Jungjjeong
Copy link
Member

@Jungjjeong Jungjjeong commented Sep 13, 2024

🤔 어떤 문제가 발생했나요?

🎉 어떻게 해결했나요?

📷 이미지 첨부 (Option)

스크린샷 2024-09-13 오후 3 20 02 스크린샷 2024-09-13 오후 3 20 12

⚠️ 유의할 점! (Option)

  • header className의 gap 변경사항이 동작하지 않아 important 사용했어요
  • 좋은 방법이 절대 아니라서 inline Style로 Props 전달하는 것이 더 괜찮을까요?

@king2dwellsang king2dwellsang added feat # Add feature Review Plz🙏 # Review is not yet complete labels Sep 13, 2024
Copy link
Collaborator

@hjy0951 hjy0951 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Sep 13, 2024
@Jungjjeong Jungjjeong merged commit 1e2eb55 into main Sep 13, 2024
5 of 6 checks passed
Copy link
Member

@wokbjso wokbjso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🔥
음 왜 gap만 동작하지 않을까요....?? 이상하네요 ㅋㅋㅋㅋ ㅠㅠ
마이페이지 headerBar 에만 동작하는 거니까 우선 개인적으로 important로 둬도 괜찮을 것 같아요..!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved 🆗 # Review is completed feat # Add feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants