Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP-369 짝꿍 특정 페이지 status bar 색상 다르게 주기 / 버그 수정 #180

Merged
merged 3 commits into from
Jan 8, 2023

Conversation

juhwankim-dev
Copy link
Member

💁‍♂️ 변경 내용

AS-IS

  • stastus bar 색상이 항상 gray 색이였습니다. gray 색이야!
  • 짝꿍 만들기 과정에서 아무것도 선택하지 않고 버튼을 누르면 앱이 죽는 버그가 있었습니다. (아무도 발견 못했길래 잠수함 패치 꼬로록...)

TO-BE

  • 특정 페이지의 status bar 색상을 흰색으로 해달라고 하셔서 변경했습니다.
  • 아무것도 선택하지 않으면 버튼이 선택되지 않게 했습니다.

📢 전달사항

plugin을 설치했더니 코드 재정렬 같은 것도 같이 들어가서 변경점이 많아보이지만
헷갈릴정도는 아닌 것 같아서 냅뒀습니다.

@juhwankim-dev juhwankim-dev added the bug Something isn't working label Jan 8, 2023
@juhwankim-dev juhwankim-dev self-assigned this Jan 8, 2023
@juhwankim-dev juhwankim-dev requested a review from a team as a code owner January 8, 2023 12:39
@juhwankim-dev juhwankim-dev merged commit 904585a into develop Jan 8, 2023
@juhwankim-dev juhwankim-dev deleted the feature/DEP-369_mate_theme_and_bug branch January 8, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant