Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP-86 feat: 목표 생성 로컬 DB와 연동 #32

Merged
merged 7 commits into from
Oct 24, 2022
Merged

DEP-86 feat: 목표 생성 로컬 DB와 연동 #32

merged 7 commits into from
Oct 24, 2022

Conversation

kimhyeing
Copy link
Contributor

@kimhyeing kimhyeing commented Oct 24, 2022 •
edited
Loading

💁‍♂️ 변경 내용

AS-IS

목표 생성 버튼을 눌러도 아무 반응이 없었습니다.

TO-BE

  • 목표 생성 버튼을 클릭하면 목표를 만드는 행동을 local db와 연동했습니다.
  • 목표 생성을 위한 data class를 제작했습니다.

📢 전달사항

  • create 함수의 파라미터를 Goal -> SaveGoalRequest로 변경하면서 주환님 코드 일부를 주석처리 했습니다 (viewModel 쪽 확인 부탁드려욥..!) @juhwankim-dev

@kimhyeing kimhyeing requested a review from a team as a code owner October 24, 2022 05:38
@kimhyeing kimhyeing self-assigned this Oct 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
16.9% 16.9% Duplication

@kimhyeing kimhyeing merged commit 558531d into develop Oct 24, 2022
@kimhyeing kimhyeing deleted the feature/DEP-86 branch October 24, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kimhyeing kimhyeing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kimhyeing