Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dep-69 fix: 목표 달성 활성 에러 해결 #36

Merged
merged 4 commits into from
Oct 24, 2022
Merged

Dep-69 fix: 목표 달성 활성 에러 해결 #36

merged 4 commits into from
Oct 24, 2022

Conversation

juhwankim-dev
Copy link
Member

💁‍♂️ 변경 내용

AS-IS

  • 오늘의 목표를 활성화 하고 다른 페이지를 갔다 오면 비활성화 되는 버그가 있었습니다.
  • lastAchievementDate에 항상 null이 들어갔습니다.

TO-BE

  • 이제 다른 페이지를 갔다 와도 활성화 상태가 유지됩니다.
  • 활성/비활성화에 따라 lastAchievementDate에 값이 변경됩니다.

📢 전달사항

@juhwankim-dev juhwankim-dev self-assigned this Oct 24, 2022
@juhwankim-dev juhwankim-dev requested a review from a team as a code owner October 24, 2022 12:45
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@juhwankim-dev juhwankim-dev merged commit 1b3f972 into develop Oct 24, 2022
@juhwankim-dev juhwankim-dev deleted the DEP-69_sequence_failed branch October 28, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@juhwankim-dev juhwankim-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juhwankim-dev