DEP-163 기기 알림 안내 바텀시트 ui 구현 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhaesung
approved these changes
Nov 30, 2022
| @@ -1,3 +1,7 @@ | |||
| <resources> | |||
| <string name="create_habit">습관 만들기</string> | |||
| <string name="noti_guide_title">기기 알림을 켜주세요!</string> | |||
| <string name="noti_guide_sub_title">알림을 켜면 짝심사일의\n모든 알림을 받아볼 수 있어요.</string> | |||
There was a problem hiding this comment.
오메 사일로 만들어버렸네요 ㅋㅋㅋ 감사합니다
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁♂️ 변경 내용
이곧내 (이미지가 곧 내용이라는 뜻)
특이사항으로는 저 중간에 회색 박스 부분은 png로 넣어 달라고 하셔서 png로 넣었습니다.
아마 저기에서 사용하는 폰트가 다른 폰트라 그냥 png로 박기로 하셨나봅니다.
svg로 해도 되는지 여쭤봤고 확정 나면 svg로 바꿔서 머지하고
png로 확정나면 해상도 별 이미지 추가해서 머지하겠습니다. (현재는 xxxhpdi만 있는 상태)