Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP-31 fix: test dependency가 없어 build가 실패하는 문제 해결 #6

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

juhwankim-dev
Copy link
Member

💁‍♂️ PR 내용

domain과 navigator 모듈에 필요한 test dependency를 추가했습니다.

@juhwankim-dev juhwankim-dev self-assigned this Oct 10, 2022
@juhwankim-dev juhwankim-dev changed the title fix: test dependency가 없어 build가 실패하는 문제 해결 DEP-31 fix: test dependency가 없어 build가 실패하는 문제 해결 Oct 10, 2022
@@ -30,5 +30,7 @@ android {
}

dependencies {
implementation deps.inject
// testing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 주석 없어도 될거같은데요.. 어떠세요 ㅎㅎ

Copy link
Member Author

@juhwankim-dev juhwankim-dev Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다 ㅎㅎ 무지성 복붙한거라 하핫..
수정했습니다!

@junhaesung
Copy link
Member

이번 코드 수정이랑은 관계없는데요. 혹시 reviewer 자동으로 지정된걸까요?

@juhwankim-dev
Copy link
Member Author

이번 코드 수정이랑은 관계없는데요. 혹시 reviewer 자동으로 지정된걸까요?

아뇨 안되는 것 같아서 수동으로 했습니다 😥

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@juhwankim-dev juhwankim-dev merged commit 547e344 into develop Oct 10, 2022
@juhwankim-dev juhwankim-dev deleted the feature/dep-31 branch October 13, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants