Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP-000 fix: 빌드 실패 해결 #62

Merged
merged 1 commit into from
Dec 10, 2022
Merged

DEP-000 fix: 빌드 실패 해결 #62

merged 1 commit into from
Dec 10, 2022

Conversation

junhaesung
Copy link
Member

@junhaesung junhaesung commented Dec 10, 2022 •
edited
Loading

💁‍♂️ 변경 내용

AS-IS

  • PR 여러개 머지하면서 수정사항 반영안된 부분있어서 빌드 실패함
    • color, textAppearance 변경사항 일부 반영 안됨
    • manifests 파일에서 lint error 발생함

TO-BE

  • 빌드 성공

📢 전달사항

  • 없음

@junhaesung junhaesung requested a review from a team as a code owner December 10, 2022 14:51
juhwankim-dev
juhwankim-dev approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@juhwankim-dev juhwankim-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니당!

@sonarcloud
Copy link

sonarcloud bot commented Dec 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@junhaesung junhaesung merged commit fae45a6 into develop Dec 10, 2022
@junhaesung junhaesung deleted the feature/fix-build-failure branch December 10, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juhwankim-dev juhwankim-dev juhwankim-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junhaesung @juhwankim-dev