refactor(checks/keyboard): change var names to distinguish being in f…

…ocus order from being focusable (#665)
dequelabs · Dec 21, 2017 · 9e8a310 · 9e8a310
1 parent d35e21a
commit 9e8a310
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/doc/rule-proposal.md b/doc/rule-proposal.md
@@ -59,7 +59,7 @@ In short sentences, using plain language, describe what conditions will lead to
 
 `###` keyboard/focusable-no-name (none)
 
-1. If the element is not focusable, return false
+1. If the element is not in the focus order, return false
 2. If the element has an accessible name, return false
 3. Otherwise return true
 

diff --git a/lib/checks/keyboard/focusable-no-name.js b/lib/checks/keyboard/focusable-no-name.js
@@ -1,6 +1,6 @@
 var tabIndex = node.getAttribute('tabindex'),
-	isFocusable = axe.commons.dom.isFocusable(node) && tabIndex > -1;
-if (!isFocusable) {
+	inFocusOrder = axe.commons.dom.isFocusable(node) && tabIndex > -1;
+if (!inFocusOrder) {
 	return false;
 }
 return !axe.commons.text.accessibleText(node);