You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When creating a <ul>, <ol> or <dl> using <dom-repeat>, you get a <dom-repeat style="display:none"> inside your list, alongside the listitems. Both only-listitems and only-dlitems report this as an issue, as the <dom-repeat> is not one of the ALLOWED_TAGS in the rule, and it ignores the fact the element is hidden with display:none. display:none should be taken in consideration as it hides the element from the accessibility tree.
Also, the pass and fail messages are incorrect for both rules. For example, the pass for only-listitems states List element only has direct children that are allowed inside <li> elements. The rule does not check for what is inside <li> elements, but what's inside <ul> or <ol> elements.
The text was updated successfully, but these errors were encountered:
)
This change allows any hidden element in ul, ol and dl elements.
Closes#1021
## Reviewer checks
**Required fields, to be filled out by PR reviewer(s)**
- [ ] Follows the commit message policy, appropriate for next version
- [ ] Has documentation updated, a DU ticket, or requires no documentation change
- [ ] Includes new tests, or was unnecessary
- [ ] Code is reviewed for security by: << Name here >>
As discussed on slack with @marcysutton and @alice.
When creating a
<ul>
,<ol>
or<dl>
using<dom-repeat>
, you get a<dom-repeat style="display:none">
inside your list, alongside the listitems. Bothonly-listitems
andonly-dlitems
report this as an issue, as the<dom-repeat>
is not one of theALLOWED_TAGS
in the rule, and it ignores the fact the element is hidden withdisplay:none
.display:none
should be taken in consideration as it hides the element from the accessibility tree.Example
Also, the pass and fail messages are incorrect for both rules. For example, the pass for
only-listitems
statesList element only has direct children that are allowed inside <li> elements
. The rule does not check for what is inside<li>
elements, but what's inside<ul>
or<ol>
elements.The text was updated successfully, but these errors were encountered: