feat(utils): add support for complex CSS selectors #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
changed the title
straker
changed the title
doc/API.md
Outdated
| @@ -68,12 +68,12 @@ For a full listing of API offered by aXe, clone the repository and run `npm run | |||
|
|
|||
| #### Supported CSS Selectors | |||
|
|
|||
| aXe supports the following CSS selectors: | |||
| Axe supports the following CSS selectors: | |||
There was a problem hiding this comment.
Change LGTM, but to be completely honest, I don't have enough exposure to this area of the codebase to be comfortable approving.
Let's wait for @WilcoFiers or @JKODU to OK this.
|
If anyone was concerned about performance, I ran these changes on a website with >11K dom nodes and >3k anchor tags. Specifically looking at the skip-link rule (which currently uses the selector
After just changing the selector to
The difference is that before the rule had to look at >3k anchor elements to determine |
WilcoFiers
previously requested changes
Apr 12, 2019
WilcoFiers
approved these changes
Apr 12, 2019
stephenmathieson
added a commit
to mohanraj-r/axe-core
that referenced
this pull request
May 10, 2019
* develop: (50 commits) docs: add jsdom example and tests (dequelabs#1530) fix(aria-valid-attr-value): allow aria-owns to pass when element is not in the DOM (dequelabs#1526) fix(isSkipLink): cache first page link (dequelabs#1525) chore: update Babel dependencies (dequelabs#1527) chore(package): Update karma to version 4.1.0 (dequelabs#1528) feat: Improve perf of axe.run [WWD-1821] (dequelabs#1503) fix(prettier): ignore generated api doc files (dequelabs#1522) fix(skip-link,region): Allow multiple skiplinks at page top (dequelabs#1496) fix(raw-reporter): do not output `DqElement`s (dequelabs#1513) fix: Scroll state had top and left properties flipped (dequelabs#1469) refactor: commons.color.getBackgroundColor method (dequelabs#1451) fix(aria-valid-attr-value): allow aria-controls to pass when element is not in the DOM chore: Update husky to the latest version 🚀 (dequelabs#1514) style: format HTML files with Prettier (dequelabs#1508) test: Fix invalid test html (dequelabs#1502) feat(rule): Inline text spacing must be adjustable with custom stylesheets (dequelabs#1446) chore: Remove version number from axe.d.ts (dequelabs#1499) chore: Update make-dir to the latest version 🚀 (dequelabs#1465) fix: Exclude iframe for html-has-lang rule (Issue 1424) (dequelabs#1430) feat(utils): add support for complex CSS selectors (dequelabs#1494) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the CSS Selector Parser to allow more complex selectors:
:not,^=,$=, and*=. Also update docs to describe what selectors we support.Closes: #1493
Reviewer checks
Required fields, to be filled out by PR reviewer(s)