refactor: commons.color.getBackgroundColor method #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
previously approved these changes
Mar 21, 2019
|
Yup, on the case. |
jeeyyy
changed the title
jeeyyy
changed the title
WilcoFiers
previously requested changes
Apr 11, 2019
WilcoFiers
previously requested changes
Apr 15, 2019
|
|
| /* This is essential to stop mocha reporter created anchors from making the document overflow, mainly along the x-axis */ | ||
| #mocha h1 a { | ||
| overflow-wrap: break-word; | ||
| word-wrap: break-word; |
There was a problem hiding this comment.
Weird indentation here. Maybe we should run Prettier over our HTML too?
There was a problem hiding this comment.
This comment wasn't resolved.
There was a problem hiding this comment.
Github decides to show it this way 🤔
scurker
reviewed
Apr 18, 2019
WilcoFiers
previously requested changes
Apr 25, 2019
| /* This is essential to stop mocha reporter created anchors from making the document overflow, mainly along the x-axis */ | ||
| #mocha h1 a { | ||
| overflow-wrap: break-word; | ||
| word-wrap: break-word; |
There was a problem hiding this comment.
This comment wasn't resolved.
| const nodeName = elm.nodeName.toUpperCase(); | ||
|
|
||
| if (graphicNodes.includes(nodeName)) { | ||
| axe.commons.color.incompleteData.set('bgColor', 'imgNode'); |
There was a problem hiding this comment.
Missing tests for imcompleteData.
There was a problem hiding this comment.
| const hasGradient = /gradient/.test(bgImageStyle); | ||
| axe.commons.color.incompleteData.set( | ||
| 'bgColor', | ||
| hasGradient ? 'bgGradient' : 'bgImage' |
There was a problem hiding this comment.
Missing tests for imcompleteData.
There was a problem hiding this comment.
See -
- https://github.com/dequelabs/axe-core/pull/1451/files#diff-e4959c7e9e75633a85787a47a13706b0R50
- https://github.com/dequelabs/axe-core/pull/1451/files#diff-e4959c7e9e75633a85787a47a13706b0R59
- https://github.com/dequelabs/axe-core/pull/1451/files#diff-e4959c7e9e75633a85787a47a13706b0R67
| * @param {Element} elm | ||
| * @return {Array} | ||
| */ | ||
| color.filteredRectStack = function(elm) { |
There was a problem hiding this comment.
This is a breaking change, please put this back on the color namespace. Apologies, I missed this in my first review round.
WilcoFiers
approved these changes
Apr 25, 2019
stephenmathieson
added a commit
to mohanraj-r/axe-core
that referenced
this pull request
May 10, 2019
* develop: (50 commits) docs: add jsdom example and tests (dequelabs#1530) fix(aria-valid-attr-value): allow aria-owns to pass when element is not in the DOM (dequelabs#1526) fix(isSkipLink): cache first page link (dequelabs#1525) chore: update Babel dependencies (dequelabs#1527) chore(package): Update karma to version 4.1.0 (dequelabs#1528) feat: Improve perf of axe.run [WWD-1821] (dequelabs#1503) fix(prettier): ignore generated api doc files (dequelabs#1522) fix(skip-link,region): Allow multiple skiplinks at page top (dequelabs#1496) fix(raw-reporter): do not output `DqElement`s (dequelabs#1513) fix: Scroll state had top and left properties flipped (dequelabs#1469) refactor: commons.color.getBackgroundColor method (dequelabs#1451) fix(aria-valid-attr-value): allow aria-controls to pass when element is not in the DOM chore: Update husky to the latest version 🚀 (dequelabs#1514) style: format HTML files with Prettier (dequelabs#1508) test: Fix invalid test html (dequelabs#1502) feat(rule): Inline text spacing must be adjustable with custom stylesheets (dequelabs#1446) chore: Remove version number from axe.d.ts (dequelabs#1499) chore: Update make-dir to the latest version 🚀 (dequelabs#1465) fix: Exclude iframe for html-has-lang rule (Issue 1424) (dequelabs#1430) feat(utils): add support for complex CSS selectors (dequelabs#1494) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring this function, to tackle the next piece of work, which is to enhance background color computation with
psuedo-elementconsideration, which will end up being another code path with in this function.What happened here:
dom.isOpaqueas it was not usedCloses issue:
Reviewer checks
Required fields, to be filled out by PR reviewer(s)