fix(flatten-tree): do not call deprecated getDistributedNodes #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
changed the title
straker
approved these changes
May 20, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<content>tag is deprecated and thegetDistributedNodes()method on it's element is also deprecated. We used to unconditionally call it, but the method was removed in Firefox, and could potentially be removed from an upcoming version of Chrome.A
<content>tag was replaced by<slot>in shadow DOM v1 and behaves like a<div>now. So it is safe to treat it like any other node.Closes issue: #1576
Reviewer checks
Required fields, to be filled out by PR reviewer(s)