Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flatten-tree): do not call deprecated getDistributedNodes #1729

Merged
merged 2 commits into from
Jul 31, 2019
Merged

fix(flatten-tree): do not call deprecated getDistributedNodes #1729

merged 2 commits into from
Jul 31, 2019

Conversation

AdnoC
Copy link
Contributor

@AdnoC AdnoC commented Jul 29, 2019 •
edited by stephenmathieson
Loading

These changes seem to have been reverted in this commit, but for a detailed explanation check the previous PR #1577.

Basically this fixes an error when running axe on certain pages in Firefox.

Closes issue: #1512

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: << Name here >>

@AdnoC AdnoC requested a review from a team as a code owner July 29, 2019 17:32
WilcoFiers
WilcoFiers previously requested changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a test.

stephenmathieson
stephenmathieson approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Also "electric boogaloo"?

@AdnoC AdnoC merged commit 46a5d11 into develop Jul 31, 2019
@AdnoC AdnoC deleted the fix-content-getdistributednodes-2-electric-boogaloo branch July 31, 2019 20:24
straker pushed a commit that referenced this pull request Aug 12, 2019
@AdnoC @straker
fix(flatten-tree): do not call deprecated getDistributedNodes (#1729)
48ddf9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

@WilcoFiers WilcoFiers WilcoFiers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdnoC @WilcoFiers @stephenmathieson