Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria-allowed-attrs): add aria-expanded to allowed attrs for menuitemcheckbox and menuitemradio #3994

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

smhigley
Copy link
Contributor

Fixes #3992

Adds aria-expanded to allowed attributes for menuitemcheckbox and menuitemradio, and updates the passes.html aria-allowed-attr tests for that attribute on those two roles.

Past context: #3343

@smhigley smhigley requested a review from a team as a code owner April 19, 2023 17:11
@straker
Copy link
Contributor

straker commented Apr 20, 2023

Awesome, thanks for this. I noticed #3343 added aria-expanded to more roles, such as checkbox and switch. Do you think those should be part of this pr or a separate pr?

@straker straker changed the title fix: add aria-expanded to allowed attrs for menuitemcheckbox and menuitemradio fix(aria-allowed-attrs): add aria-expanded to allowed attrs for menuitemcheckbox and menuitemradio Apr 26, 2023
@straker
Copy link
Contributor

straker commented Apr 26, 2023

Reviewed for security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive aria-allowed-attr for aria-expanded on menuitemcheckbox and menuitemradio
2 participants