Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the accessibility rules configured in the jest-axe library. #28

Closed
AtishayMsft opened this issue Jan 12, 2024 · 3 comments
Closed

Comments

@AtishayMsft
Copy link
Collaborator

Investigate the accessibility rules configured in the jest-axe library in fluent repo https://github.com/microsoft/fluentui/blob/d8321c5e8191f94e9413aee0e800f96d3de8e311/package.json#L251.

Our baseline is the accessibility insights web tool which keeps on adding more rules and checks in their releases.
Refer https://github.com/microsoft/accessibility-insights-web/releases/tag/[email protected]
Are the rules in jest-axe dependency upto date.
If not, then how to update these rules to represent the current standard.

Assigned to @Shubhabrata08

@Shubhabrata08
Copy link
Contributor

The repo is at 6.0.1 whereas the latest is at 8.0.0.
axe-core has been updated from 4.4.1 to 4.7.2
image

@Shubhabrata08
Copy link
Contributor

Here are a list of changes to axe-core from v4.4.1 to v4.7.2

4.7.2 (2023-05-25)

Bug Fixes

  • aria-allowed-attr: Add 'aria-required' to switch role (#4029) (cb51be4), closes #4027
  • aria-allowed-attr: allow aria-required on role=slider (#4035) (bb2bf60)
  • aria-required-children: set related nodes for invalid children (#4033) (377f72b)
  • tags: Add / correct several TTv5 tags (#4031) (25859dd)

4.7.1 (2023-05-15)

Bug Fixes

  • aria-allowed-attr: no inconsistent aria-checked on HTML checkboxes (#3895) (704043e)
  • aria-allowed-attrs: add aria-expanded to allowed attrs for menuitemcheckbox and menuitemradio (#3994) (0f405c6)
  • aria-required-children: trigger reviewEmpty with hidden children (#4012) (a19b6cb)
  • color-contrast: support CSS 4 color spaces (#4020) (65621c3)
  • link-in-text-block: set links with pseudo-content for review (#4005) (949f4f8)

4.7.0 (2023-04-17)

Features

  • aria-roledescription: deprecate rule (#3948) (1913a9e)
  • aria-roles: deprecate the ARIA directory role (#3952) (893fdd0)
  • d.ts: setup/teardown, reporters & metadata definitions (#3966) (78264ee)
  • deprecate bower (#3889) (651d811)
  • deprecate color.filteredRectStack, color.getRectStack, and dom.visuallyContains (#3859) (3be2bad)
  • dom.focusDisabled,dom.isVisibleForScreenreader: support the inert attribute (#3857) (273c971)
  • metadata: add Trusted Tester tag (#3986) (1f6a2a6)
  • support the dialog element (#3902) (d4522cd)

Bug Fixes

  • aria-allowed-attrs: allow aria-description and aria-braille* attrs (#3956) (2842395)
  • aria-input-field-name: skip combobox popups (#3886) (3dcdd42)
  • aria-required-children: allow separator in menu(bar) (#3868) (ec9f507)
  • aria-required-children: do not fail for children with aria-hidden (#3949) (8714d6b)
  • aria-required-children: list elements that are not allowed (#3951) (cce7586)
  • autocomplete-valid: allow webauthn token (#3866) (fd3010f)
  • color-contrast: correcly apply opacity to foreground color (#3973) (d7db279)
  • color-contrast: correctly calculate contrast of flex/grid items with z-index (#3884) (cef96be)
  • color-contrast: correctly compute background color for elements with opacity (#3944) (c051fe8), closes #3932
  • color-contrast: correctly compute color contrast of elements (#3847) (4c3a00c)
  • color-contrast: do not check contrast on elemets that are inerted (#3894) (da19946)
  • color-contrast: skip ligature icons (#3867) (9486288)
  • create-grid: correctly compute stack order for non-positioned stacking contexts (#3930) (8db2c24), closes #3932
  • css-orientation-lock: support the css rotate property (#3958) (c51f8bf)
  • focus-order-semantics: Add ARIA role article to list of valid roles for scrollable regions (#3927) (f029271)
  • is-icon-ligature: prevent canvas2d warning willReadFrequently (#3931) (b3c52bb)
  • link-in-text-block: allow links with identical colors (#3861) (5f90040)
  • respondable: work with CDP Page.setDocumentContent (#3921) (66f23e5)
  • scrollable-region-focusable: change impact to serious (#3959) (e3a5c21)
  • scrollable-region-focusable: skip native controls (#3862) (b0bdefa)

4.6.3 (2023-01-23)

Bug Fixes

  • aria-required-children: allow separator in menu(bar) (#3868) (46c9499)
  • autocomplete-valid: allow webauthn token (#3866) (a3d1b9d)
  • color-contrast: correctly compute color contrast of elements (#3847) (844cea1)
  • color-contrast: skip ligature icons (#3867) (7dfbd9a)
  • link-in-text-block: allow links with identical colors (#3861) (6761f36)
  • scrollable-region-focusable: skip native controls (#3862) (aaf44e9)

4.6.2 (2022-12-23)

Bug Fixes

  • color-contrast: fix color-contrast check when running in an extension (#3838) (31a3e01)

4.6.1 (2022-12-14)

Bug Fixes

  • d.ts: add optional include to ContextObject (#3830) (36ed242)

4.6.0 (2022-12-12)

Features

  • aria-required-attr: require aria-controls on combobox and aria-valuenow on focusable separator (#3786) (5259e88)
  • checks/label-content-name-mismatch: deprecate occuranceThreshold option in favor of occurrenceThreshold to fix typo (#3782) (5026d65)
  • commons: deprecate flattenShadowColors in favor of flattenColors (#3792) (af49daf)
  • context: allow selecting shadow DOM nodes (#3798) (9e1e31b)
  • list,listitem: do not allow group as allowed parent or child (#3784) (d1cbf6f)
  • required-attr: require aria-checked for checkbox-like and radio-like roles (#3785) (563e4e9)
  • utils: new shadowSelectAll utility (#3796) (5865462)

Bug Fixes

  • aria-allowed-role: allow combobox on button, checkbox and combobox on input[type=button] (#3354) (ac688c0), closes #3353
  • aria-required-children: allow menu as child of menu (#3820) (a6569e5)
  • color-contrast: consider -webkit-text-stroke & -webkit-text-fill-color (#3791) (228daf1)
  • color-contrast: correctly calculate background color of text nodes with different size than their container (#3703) (123b83c)
  • get-role: handle presentation role inheritance for vnodes with no parent (#3801) (b971caf)
  • html-lang-valid: only run rule when attribute has value (#3663) (1a7eecb), closes #3624
  • metadata: Map aria-required-children to ACT rule bc4a75 (#3790) (a33a523)

4.5.2 (2022-11-14)

Bug Fixes

  • aria-required-children: allow menu and menubar to be empty (#3770) (d11aed8)
  • create-grid: include elements scrolled out of view in the grid (#3773) (a563263)
  • do not warn when using webpack (#3777) (d6cef9a)
  • link-in-text-block: don't match style or script text (#3775) (ab877f9)
  • prevent undefined relatedNodes from halting axe (#3778) (efefb18)

4.5.1 (2022-11-01)

Bug Fixes

  • allow axe to run in certain configurations of jsdom (#3755) (b74c5d4)
  • prevent crash on jsdom when preloading CSSOM (#3754) (b1f0c6b)

4.5.0 (2022-10-17)

Features

Highlights

  • new rule: Add WCAG 2.2 target-size rule (off by default) (#3616) (691f1b6)
  • new rule: Add meta-refresh-no-exceptions (off by default, wcag2aaa) (#3530) (27031a8)
  • identical-links-same-purpose: Disable by default (wcag2aaa rule) (#3615) (a2c2d2f)
  • link-in-text-block: Remove experimental and enable by default (#3706) (37b6e7a)
  • i18n: Add Norwegian Bokmål locale (#3375) (2886d33)
  • i18n: Add Hebrew translation (#3438) (b4162ed)

Tags and Metadata Updates

Various changes of tags, for greater consistency with ACT Rules.

  • area-alt: Remove the wcag111 tag (#3479) (1c3cc51)
  • aria-hidden-focus: Remove the wcag131 tag (#3477) (36ace76)
  • empty-table-headers: Rule is now best-practice and fails instead of incompletes (#3427) (0a4397d), closes #3404
  • frame-title: Remove wcag241 tag (#3519) (9c6b828)
  • input-image-alt: Add the wcag412 tag (#3478) (34272c6)
  • label,select-name: Remove the sc131 tag (#3476) (7caef89)
  • meta-viewport: Report as violation of wcag 1.4.4 (#3704) (6f7e4a9)
  • metadata: Update ACT tags & actIds (#3498) (571722b)

Deprecations

  • Deprecate Internet Explorer support (#3644) (11f5163)
  • Deprecate sri-history.json file (#3646) (6f6a89e)
  • Deprecate and replace dom.isVisible, utils.isHidden, and dom.isHiddenWithCss (#3351) (1ae2ac0)
  • Deprecate only-dlitems-evaluate & only-listitems-evaluate methods (#3724) (322e9ed)
  • Deprecate presentation-role-conflict-matchess (#3638) (0f02a15)
  • Deprecate is-visible-matches, use is-visible-on-screen-matches (#3679) (738dd8f)
  • Deprecate not-html-matches, use :not(html) instead (#3540) (e0010d9)

Others

  • aria-roles: Permit fallback roles (#3683) (5665260)
  • aria-required-children: Allow aria-busy on children (#3569) (3618f50)
  • aria-required-children: Fail for children which are not listed as required (#3597) (b5ceabc)
  • getRules: Return actIds when set (#3470) (a3d5cef)
  • is-in-tab-order: Add isInTabOrder to commons (#3619) (77afe90), closes #3500
  • list/definition-list: Only allow required owned roles (#3707) (a920d35)
  • presentation-role-conflict: Test img elements with empty alt (#3717) (ea32fa7)

Bug Fixes

  • utils: greatly improve the speed of querySelectorAll (#3423) (1cae5ea)
  • aria-hidden-focus: Do not fail for focus trap bumper elements (#3667) (46b6658)
  • aria-required-attr: aria-valuenow is no longer required for spinbutton (#3552) (a22cf56)
  • aria-required-parent: Allow nested group and presentational roles (#3492) (4685270)
  • aria-valid-attr-value: Report empty values as incomplete (#3635) (fff39db)
  • avoid-inline-spacing: Add spacing threshold (#3533) (92add05)
  • checks/no-focusable-disable: Don't count non-disableable elements as disabled (#3393) (bb8b5ca), closes #2466 #2934 #2934 #3315
  • checks/unsupportedrole: Support unsupported dpub and fallback roles, add role to message (#3395) (3c0f10f), closes #2466 #2934 #2934 #3282
  • color-contrast-enhanced: Avoid duplicates between color-contrast and color-contrast-enhanced (#3714) (2811f77)
  • color-contrast: Correctly determine color contrast for element that exactly overlaps midpoint of node (#3565) (90de9aa)
  • frame-focusable-content: don't fail for elements with negative tabindex (#3493) (94e75ac)
  • frame-title-unique: Make frame-title-unique reviewOnly and WCAG412 (#3610) (8401b8e), closes #3487
  • frame-title: ignore frames with negative tabindex (f61f825)
  • frame-title: return incomplete for presentational iframe with empty title (#3594) (c2cfd84)
  • is-hidden-for-everyone: count elements inside closed details as hidden (#3726) (e65e962)
  • is-hidden-for-everyone: support content-visibility: hidden (#3690) (95cf6e7)
  • is-visible-on-screen: ignore elements hidden by overflow:hidden (#3676) (2935950)
  • label: avoid passing labels because of an input[value] (#3688) (54a8116)
  • link-in-text-block: Update rule to match current guidance, revise tests (#3575) (edb88ed)
  • meta-refresh: Add WCAG's 20-hour exception (#3525) (5beb6c3)
  • no-autoplay-audio: add reviewOnFail and update tests (#3557) (60ec997)
  • object-alt: ignore unloaded objects (#3680) (8e03e2c)
  • page-has-heading-one,landmark-one-main: do not fail if modal is open (#3501) (c6af316)
  • td-headers-attr: ignore hidden cells with headers attr (#3684) (e0403f4)
  • td-headers-attr: ignore table elements with their role changed (#3687) (902d07c)
  • utils.matches: fix attribute exists selector to match empty attributes (#3669) (4b768ea)
  • valid-lang: ignore lang on elements with no text (#3523) (fd85f39)
  • valid-lang: run on aria-hidden text (#3634) (a0860bd)
  • video-caption: remove excludeHidden: false (#3554) (a3e4bbe)

4.4.3 (2022-07-13)

Bug Fixes

4.4.2 (2022-05-12)

Bug Fixes

  • aria-hidden-focusable: report incomplete with onfocus (#3407) (6755e89)
  • aria-hidden-focus: Update rule help & description (#3422) (7cfb4b1)
  • aria-valid-attr-value: add note about element id being in a different shadow DOM tree (#3421) (24f74df)
  • color-contrast: consistently return color contrast information in the data object for pseudo elements (#3453) (1a9d95e)
  • deprecatedrole,color-contrast: fix message to properly include deprecated role, improve color-contrast pass messages (#3387) (650e503)
  • html-elms: update role allowances for nav element (#3402) (8aa816a), closes #3401
  • standards: fix address typo in html-elms.js (#3418) (f235cc7), closes #3417

@AtishayMsft
Copy link
Collaborator Author

Issue fixed with PR# microsoft/fluentui#30309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants