fix: handle noscript and template in dom.isVisible #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcysutton
reviewed
Nov 27, 2018
| @@ -56,8 +56,7 @@ dom.isVisible = function(el, screenReader, recursed) { | |||
|
|
|||
| if ( | |||
| style.getPropertyValue('display') === 'none' || | |||
| nodeName.toUpperCase() === 'STYLE' || | |||
| nodeName.toUpperCase() === 'SCRIPT' || | |||
| ['STYLE', 'SCRIPT', 'NOSCRIPT', 'TEMPLATE'].includes(nodeName) || | |||
There was a problem hiding this comment.
Is nodeName always uppercase?
There was a problem hiding this comment.
@marcysutton - the line above does the uppercasing already - https://github.com/dequelabs/axe-core/pull/1257/files#diff-a871adbd9186fdb557c3a1171796b6d8R55
|
@JKODU I would prefer if this change could be squashed or rebased before merging. |
dylanb
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst solving for a non-reproducible
regionrule bug (#864), decided to enhance currentdom.isVisibleimplementation to cater fornoscriptandtemplatetags.Closes issue: NA
Reviewer checks
Required fields, to be filled out by PR reviewer(s)