ci: replce hub with gh CLI
#4326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-siek
changed the title
hub with gh CLI
dbjorge
requested changes
Feb 5, 2024
.github/workflows/release.yml
Outdated
| echo "$ReleaseNotes" >> /tmp/pr.txt | ||
| echo "" >> /tmp/pr.txt | ||
| echo "This PR was opened by a robot :robot: :tada:" >> /tmp/pr.txt | ||
| hub pull-request --file /tmp/pr.txt --base master | ||
| gh pr create --title "chore(release): v$Version" --body-file "/tmp/pr.txt" --base release |
There was a problem hiding this comment.
Is it intentional that this changes the base from master to release? Do the two commands use --base to mean different things?
dbjorge
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
hubwas removed from all newer versions of GitHub Actions and users are required to install it on their systems to be able to use it. Instead of usinghubthis PR replaces it withghcliNo QA required