Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context completion broken with mixed case context names #2401

Closed
omry-arpaly opened this issue Dec 28, 2023 · 2 comments
Closed

Context completion broken with mixed case context names #2401

omry-arpaly opened this issue Dec 28, 2023 · 2 comments
Labels
bug Something isn't working InProgress Marks an issue has being worked on

Comments

@omry-arpaly
Copy link

omry-arpaly commented Dec 28, 2023 •
edited
Loading




Describe the bug
Context completion, using @ symbol in the prompt line, breaks when using contexts with mixed case (e.g., "Dev-US")

To Reproduce

  1. Have a mixed case context defined in kubeconfig
  2. Enter something like "po @d" on the command prompt
  3. No completion attempt is made
  4. Enter something like "po @A" on the command prompt
  5. Get completion for context names that are all lowercase. (e.g., "arn:aws:eks:....")

Expected behavior
Suggestions should work in a case-insensitive manner

Versions (please complete the following information):

  • OS: MacOS 13.6.3
  • K9s: 0.30.5
  • K8s: 1.24

Additional context
This is probably related to #2389 and #2390
@derailed derailed added bug Something isn't working InProgress Marks an issue has being worked on labels Dec 28, 2023
@derailed
Copy link
Owner

@omry-arpaly Great catch! Thank you for the heads up!!

derailed added a commit that referenced this issue Dec 28, 2023
@derailed
fix #2401
f9c5fc1
@derailed derailed mentioned this issue Dec 28, 2023
Merged
@omry-arpaly
Copy link
Author

Thanks for the quick fix! 😎

thejoeejoee pushed a commit to thejoeejoee/k9s that referenced this issue Feb 23, 2024
@derailed @thejoeejoee
K9s/release v0.30.6 (derailed#2403)
be3f764 
* fix derailed#2401

* fix derailed#2400

* fix derailed#2387

* rel notes
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this issue Apr 3, 2024
@derailed
K9s/release v0.30.6 (derailed#2403)
a24f7bf 
* fix derailed#2401

* fix derailed#2400

* fix derailed#2387

* rel notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working InProgress Marks an issue has being worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derailed @omry-arpaly