Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.30.7 - windows 10 default skin pods lost colors #2425

Closed
Slach opened this issue Jan 3, 2024 · 11 comments
Closed

0.30.7 - windows 10 default skin pods lost colors #2425

Slach opened this issue Jan 3, 2024 · 11 comments
Labels
bug Something isn't working question Further information is requested

Comments

@Slach
Copy link

Slach commented Jan 3, 2024




Describe the bug
One screenshot instead of 1000 words
0.30.7

0.30.6

To Reproduce
Steps to reproduce the behavior:

scoop install k9s
k9s.exe

Expected behavior
correct

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

  • OS: Windows 10
  • K9s: 0.30.7
  • K8s: any
@flamadrid-jsmdg
Copy link

same on mac

@derailed
Copy link
Owner

derailed commented Jan 3, 2024

@Slach @flamadrid-jsmdg Thanks you both for the heads up!
Can't repro here at the ranch ;(
Could you share more details about your envs and the k9s debug logs?

@derailed derailed added bug Something isn't working question Further information is requested labels Jan 3, 2024
@flamadrid-jsmdg
Copy link

flamadrid-jsmdg commented Jan 3, 2024

It seems the skin is not applied at the start, and only applied after selecting the cluster.
My config.yaml look like

k9s:
  liveViewAutoRefresh: false
  refreshRate: 2
  maxConnRetry: 5
  readOnly: false
  noExitOnCtrlC: false
  ui:
    enableMouse: false
    headless: false
    logoless: false
    crumbsless: false
    noIcons: false
    skin: default
    skipLatestRevCheck: false
  disablePodCounting: false
  shellPod:
    image: busybox:1.35.0
    namespace: default
    limits:
      cpu: 100m
      memory: 100Mi
  imageScans:
    enable: false
    exclusions:
      namespaces: []
      labels: {}
  logger:
    tail: 100
    buffer: 5000
    sinceSeconds: -1
    fullScreenLogs: false
    textWrap: false
    showTime: false
  thresholds:
    cpu:
      critical: 90
      warn: 70
    memory:
      critical: 90
      warn: 70

@derailed
Copy link
Owner

derailed commented Jan 3, 2024

@flamadrid-jsmdg Thank you for the details Francisco! Still can't repro here on osx using v0.30.7 using your base config??
I thought the issue was skin: default which does not exist but no dice ;(
What am I missing?

Screenshot 2024-01-03 at 11 06 17 AM

@flamadrid-jsmdg
Copy link

So I rename it to default but the file was called dracula, it was happening as well anyway. I'm not sure why it does not load at startup. The env var $XDG_CONFIG_HOME = ~/Library/Preference and the skin is in ~/Library/Preference/k9s/skins/default.yaml
Anyway, is not that a big deal it doesnt load at startup

@derailed
Copy link
Owner

derailed commented Jan 4, 2024

@flamadrid-jsmdg Thanks for the details Francisco!
Can you share your k9s debug logs? It could be something is hosed with your skin??

@flamadrid-jsmdg
Copy link

@derailed here is the k9s.log

4:39PM INF 🐶 K9s starting up...
4:39PM ERR refine failed error="getcontext - invalid context specified: \"\""
4:39PM ERR Fail to locate metrics-server error="Get \"http://localhost:8080/api?timeout=32s\": dial tcp [::1]:8080: connect: connection refused"
4:39PM ERR load configuration failed error="Get \"http://localhost:8080/api?timeout=32s\": dial tcp [::1]:8080: connect: connection refused"
4:39PM ERR Unable to assert active namespace. Using default error="context config is not set"
4:39PM WRN namespace validation failed for: "default" error="no connection to dial"
4:39PM ERR Load cluster resources - No API server connection
4:39PM ERR failed to list contexts error="no connection"
4:39PM WRN CustomView watcher failed error="open /Users/Fran/Library/Preferences/k9s/views.yaml: no such file or directory"
4:39PM ERR Unable to assert active namespace. Using default error="context config is not set"
4:39PM ERR Unable to assert active namespace. Using default error="context config is not set"
4:39PM ERR Unable to assert active namespace. Using default error="context config is not set"
4:39PM ERR Unable to assert active namespace. Using default error="context config is not set"
4:39PM ERR can't connect to cluster error="Get \"http://localhost:8080/version?timeout=15s\": dial tcp [::1]:8080: connect: connection refused"
4:39PM ERR Load cluster resources - No API server connection
4:39PM WRN Unable to dial discovery API error="no connection to cached dial"
4:39PM WRN Fail CRDs load error="`list access denied for user on \"\":apiextensions.k8s.io/v1/customresourcedefinitions"
4:39PM WRN Cluster metrics failed error="`list access denied for user on \"\":metrics.k8s.io/v1beta1/nodes"
4:39PM WRN CustomView watcher failed error="open /Users/Fran/Library/Preferences/k9s/views.yaml: no such file or directory"
4:39PM WRN Cluster metrics failed error="user is not authorized to list node metrics"
4:39PM WRN Fail CRDs load error="[list] access denied on resource \"-\":\"apiextensions.k8s.io/v1/customresourcedefinitions\""

@flamadrid-jsmdg
Copy link

flamadrid-jsmdg commented Jan 4, 2024

can it be that it supposed to work like this? So when k9s starts up, no skin is used, but then once selecting the cluster if there a specific skin cluster configured, that will be used, if not the one under k9s.ui.skin in the config.yaml will be used (cluster's default)
Another note: my dracula skin is copy/paste from the one here in the repo, haven't changed anything in it.

@Slach
Copy link
Author

Slach commented Jan 4, 2024

looks like error doesn't reproduce in 0.30.8 from my side
I don't have any skins and clean C:\Users\USER\AppData\Local\k9s\ before restart

@Slach Slach closed this as completed Jan 4, 2024
@flamadrid-jsmdg
Copy link

Yeah the issue I have is different at the stated in this issue indeed, is not about the colors that was fix in 30.8 but rather the skin not loading at startup. I can live with it though :)

@derailed
Copy link
Owner

derailed commented Jan 4, 2024

@flamadrid-jsmdg Right! I've missed this crucial detail completely i.e you are starting k9s with either no context or a bummed one. Aye!

derailed added a commit that referenced this issue Jan 9, 2024
derailed added a commit that referenced this issue Jan 9, 2024
derailed added a commit that referenced this issue Jan 9, 2024
* cleaning up

* [Bug] Fix #2425 - no context skin issue

* [Bug] Fix #2428

* [Feat] schema validation

* v0.31.0 Release notes
thejoeejoee pushed a commit to thejoeejoee/k9s that referenced this issue Feb 23, 2024
* cleaning up

* [Bug] Fix derailed#2425 - no context skin issue

* [Bug] Fix derailed#2428

* [Feat] schema validation

* v0.31.0 Release notes
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this issue Apr 3, 2024
* cleaning up

* [Bug] Fix derailed#2425 - no context skin issue

* [Bug] Fix derailed#2428

* [Feat] schema validation

* v0.31.0 Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants