Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrong/redundant icon in the prompt bar #2105

Merged
merged 1 commit into from
May 28, 2023

Conversation

wjiec
Copy link
Contributor

@wjiec wjiec commented May 26, 2023

When performing command or filter, multiple icons (wrong or duplicates) are displayed in the prompt bar.

This problem is caused by duplicate listener registration in CmdBuff.listeners.

@wjiec
Copy link
Contributor Author

wjiec commented May 26, 2023

for example, when enter logs and performing filter
Snipaste_2023-05-26_13-02-57
or changes the resource(deploy -> statefulset) and enter the logs with filter
Snipaste_2023-05-26_13-03-29

@wjiec wjiec marked this pull request as draft May 26, 2023 05:11
@wjiec wjiec marked this pull request as ready for review May 26, 2023 05:32
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjiec Nice catch. Thank you Jayson!

@derailed derailed merged commit d383788 into derailed:master May 28, 2023
@wjiec wjiec deleted the bugix/prompt-icon branch May 28, 2023 15:02
@derailed derailed mentioned this pull request Nov 8, 2023
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants