This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Update to [email protected] and [email protected]. #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derat
commented
Oct 26, 2021
src/views/Login.vue
Outdated
| // See https://github.com/firebase/firebaseui-web/issues/293. | ||
| let ui = firebaseui.auth.AuthUI.getInstance(); | ||
| if (!ui) ui = new firebaseui.auth.AuthUI(auth); | ||
| Promise.all([getAuth(), getFirebaseUI()]).then(([auth, firebaseui]) => { |
There was a problem hiding this comment.
prettier changed the indenting, but the only change i made here was to remove the getFirebase() call
src/views/Login.vue
Outdated
| // https://stackoverflow.com/q/37369929 | ||
| credentialHelper: firebaseui.auth.CredentialHelper.NONE, | ||
| signInOptions: [ | ||
| // These correspond to the static variables |
There was a problem hiding this comment.
i also added this comment and the two strings below
|
this change is totally fucked |
I initially tried to go to [email protected], the current release, but it redoes the way that module imports work. It seems straightforward to update our code to use the 'compat' versions of the modules per the instructions at https://firebase.google.com/docs/web/modular-upgrade, but the third-party vuefire package doesn't seem to have been updated yet (vuejs/vuefire#1128) so we're stuck at version 8 for now. Also switch from the deprecated @firebase/testing package to @firebase/rules-unit-testing. Luckily, it seems to be a drop-in replacement. To get all of this working, I also ripped out all of the code I'd written before to asynchronously import Firebase modules. It made the code way more complicated for what was probably only a little bit of improvement in loading time, and I spent a lot of time trying to figure out how to update it to work with version 8 of the Firebase API before giving up. Version 9 finally supports tree-shaking, so hopefully things will get faster again when we're able to upgrade to it.
derat
force-pushed
the
update_firebase
branch
from
7118d5d
to
39fdec9
Compare
|
okay, i guess i got this working :-/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially tried to go to [email protected], the current
release, but it redoes the way that module imports work. It
seems straightforward to update our code to use the 'compat'
versions of the modules per the instructions at
https://firebase.google.com/docs/web/modular-upgrade, but
the third-party vuefire package doesn't seem to have been
updated yet (vuejs/vuefire#1128)
so we're stuck at version 8 for now.
Also switch from the deprecated @firebase/testing package to
@firebase/rules-unit-testing. Luckily, it seems to be a
drop-in replacement.