-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More intl. titles #99
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just want to double check confirm that none of these things could potentially be a first name, but it all looks pretty good.
@@ -289,7 +290,13 @@ | |||
'foreign', | |||
'forester', | |||
'founder', | |||
'fr', | |||
'frau', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not too familiar with German, but we just need to make sure that things in the titles constant are not things that might conceivably be a first name. This would mean that anyone named Frau would have their name parsed incorrectly. When there's two right ways to parse a name, the parser prefers to parse first and last name correctly over titles. Is "Frau" ever used as a first name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not be able to think of "Frau" being used as a first name. "Frauke" is a first name, but "Frau" used to be a sign for nobility (as in "Freifrau") in the middle ages, and trickled down to a common denominator of sex/gender lateron. So it would be common to be used in appellative function or when addressing a female person in writing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I these are all very legitimate and common titles.
Maybe a bit philosophical at this stage, but ... People can be named the strangest things, so requiring the categories to be distinct is unrealistic in my opinion. I think the role of this library should be to make a "best guess", probably not ONLY based on whether it matches these data points. The amount words and categories of there are also very important factors that the library could take into account (in some future version). For example, I definitely know of people named Prince
or Sheikh
as their first names. So if we come across such words, we probably need to look at the context to make a best guess about what it means. Same thing applies to the prefixes like "Van" which are very common prefixes but also first names and possibly (unlikely IMO) middle names.
I came to make a pull request for 'herr' and 'frau' and found that there is one already. Any blockers I could help working on to get this merged & released @derek73 ? Add some tests? |
No description provided.