Add some ignores for nullable vlues into non-nullable Futures. (flutt…

…er#6927)
derekxu16 · Dec 14, 2023 · c43e600 · c43e600
1 parent 9950214
commit c43e600
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/devtools_app/lib/src/shared/config_specific/logger/_allowed_error_default.dart b/packages/devtools_app/lib/src/shared/config_specific/logger/_allowed_error_default.dart
@@ -16,6 +16,9 @@ Future<T> allowedError<T>(Future<T> future, {bool logError = true}) {
       _log.shout('[${error.runtimeType}] ${errorLines.first}');
       _log.shout(errorLines.skip(1).join('\n'));
     }
+    // TODO(srawlins): This is an illegal return value (`null`) for all `T`.
+    // This function must return an actual `T`.
+    // ignore: null_argument_to_non_null_type
     return Future<T>.value();
   });
 }
diff --git a/packages/devtools_app/lib/src/shared/config_specific/logger/_allowed_error_web.dart b/packages/devtools_app/lib/src/shared/config_specific/logger/_allowed_error_web.dart
@@ -17,6 +17,9 @@ Future<T> allowedError<T>(Future<T> future, {bool logError = true}) {
       console.log(errorLines.skip(1).join('\n').toJS);
       console.groupEnd();
     }
+    // TODO(srawlins): This is an illegal return value (`null`) for all `T`.
+    // This function must return an actual `T`.
+    // ignore: null_argument_to_non_null_type
     return Future<T>.value();
   });
 }