specs for fail statements, replaces fail {'':} with functions

deric · Feb 9, 2015 · ee4a915 · ee4a915
1 parent 023e234
commit ee4a915
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 2 deletions.
diff --git a/manifests/repo.pp b/manifests/repo.pp
@@ -21,7 +21,7 @@
                 $repourl = "http://archive.cloudera.com/cdh${cdhver}/redhat/6/${::hardwaremodel}/cdh/cloudera-cdh${cdhver}.repo"
               }
               default: {
-                fail { "Yum repository '${source}' is not supported for architecture ${::hardwaremodel}": }
+                fail("Yum repository '${source}' is not supported for architecture ${::hardwaremodel}")
               }
             }
             case $osrel {
@@ -35,7 +35,7 @@
                 }
               }
               default: {
-                fail { "Yum repository '${source}' is not supported for redhat version ${::osrel}": }
+                fail("Yum repository '${source}' is not supported for redhat version ${::osrel}")
               }
             }
           }

diff --git a/spec/classes/repo_spec.rb b/spec/classes/repo_spec.rb
@@ -30,4 +30,35 @@
 
     it_behaves_like 'redhat-install', 'RedHat', '6'
   end
+
+  context 'fail when architecture not supported' do
+    let(:facts) {{
+      :osfamily => 'RedHat',
+      :hardwaremodel => 'arc',
+    }}
+
+    let(:params) { {
+      :source => 'cloudera',
+    } }
+
+    it { expect {
+        should compile
+    }.to raise_error(/is not supported for architecture/) }
+  end
+
+  context 'fail when release not supported' do
+    let(:facts) {{
+      :osfamily => 'RedHat',
+      :operatingsystemmajrelease => '7',
+      :hardwaremodel => 'x86_64',
+    }}
+
+    let(:params) { {
+      :source => 'cloudera',
+    } }
+
+    it { expect {
+        should compile
+    }.to raise_error(/is not supported for redhat version/) }
+  end
 end