Replace sh with bash in systemd unit #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since zookeeper v3.4.6 zkEnv.sh uses bash as a shebag. Moreover
it contains operations with arrays which sh (dash) doesn't
support. Because of it systemd unit doesn't work and fails with
following errors:
/bin/sh: 81: /opt/zookeeper-3.4.11/bin/zkEnv.sh: Syntax error: "(" unexpected (expecting "fi")
Error: Could not find or load main class org.apache.zookeeper.server.quorum.QuorumPeerMain
This patch replaces sh with bash in sytemd unit thereby fixes
that problem.
|
+1 - This impacted us during an archive install on Xenial. |
|
Thanks for the PR! I'll draft a new patch-release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since zookeeper v3.4.6 zkEnv.sh uses bash as a shebag. And moreover the script contains operations with arrays which sh (dash) doesn't support. Because of it systemd unit doesn't work and fails with following errors:
This patch replaces sh with bash in sytemd unit thereby fixes that problem.