allow configuring additional log appenders #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deric
requested changes
Nov 22, 2019
templates/conf/log4j.properties.erb
Outdated
| @@ -65,3 +65,9 @@ log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil | |||
| log4j.appender.TRACEFILE.layout=org.apache.log4j.PatternLayout | |||
| ### Notice we are including log4j's NDC here (%x) | |||
| log4j.appender.TRACEFILE.layout.ConversionPattern=%d{ISO8601} [myid:%X{myid}] - %-5p [%t:%C{1}@%L][%x] - %m%n | |||
| <% @extra_appenders.each_pair do |name, data| -%> | |||
There was a problem hiding this comment.
It might be a good idea to add a .sort here, in order to avoid unnecessary changes each puppet run.
templates/conf/log4j.properties.erb
Outdated
| @@ -65,3 +65,9 @@ log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil | |||
| log4j.appender.TRACEFILE.layout=org.apache.log4j.PatternLayout | |||
| ### Notice we are including log4j's NDC here (%x) | |||
| log4j.appender.TRACEFILE.layout.ConversionPattern=%d{ISO8601} [myid:%X{myid}] - %-5p [%t:%C{1}@%L][%x] - %m%n | |||
| <% @extra_appenders.each_pair do |name, data| -%> | |||
|
|
|||
| <% data.each_pair do |key, value| -%> | |||
There was a problem hiding this comment.
Same here, data.sort.each_pair is a preferred way
|
Looks good, thanks! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-zookeeper
that referenced
this pull request
Sep 7, 2020
* allow configuring additional log appenders * sort() produces an array of arrays, so we need to replace each_pair() with map()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to configure additional appenders in
log4j.properties, useful e.g. for getting Zookeeper to log to syslog.