Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ciphersuite variable on zoo.cfg.erb #186

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

JeanMichelApeupres
Copy link
Contributor

Hi,

There seems to be a typo within the zoo.cfg.erb template when configuring the TLS ciphers.
The lookups seem to be wrong :

<% if scope.lookupvar("zookeeper::zookeeper:ssl_ciphersuites") %>
# Set allowed Ciphers
ssl.ciphersuites=<%= scope.lookupvar("zookeeper:ssl_ciphersuites") %>
<% end -%>

So I'm submitting this quickfix :

<% if scope.lookupvar("zookeeper::ssl_ciphersuites") %>
# Set allowed Ciphers
ssl.ciphersuites=<%= scope.lookupvar("zookeeper::ssl_ciphersuites") %>
<% end -%>

Same goes for the ssl_quorum_ciphersuites declaration.

@deric
Copy link
Owner

deric commented Jan 10, 2023

Good catch, thanks!

@deric deric merged commit 89efa07 into deric:master Jan 10, 2023
@JeanMichelApeupres
Copy link
Contributor Author

You're welcome @deric, could you create a new tag with the latest modifications ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants