fixes #187 ssl ciphersuites is optional, and removed when not set #188
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xepa
changed the title
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will make
$ssl_ciphersuitesand$ssl_quorum_ciphersuitesoptional and will not define them in zoo.cfgPreviously a none supplied ciphersuite would defined the following in zoo.cfg leading to the following Exception
Exception in thread "QuorumConnectionThread-[myid=1]-72" java.lang.IllegalArgumentException: The specified CipherSuites array contains invalid null or empty string elementsFix for issue: #187