Fix hashtable rebuilding logic to not corrupt hashtables #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in b0e6d19
unfortunately corrupted the hashtables by picking raw chunks
in increasing order rather than picking the correct raw chunk.
Note that this broke all hashtables, not just dtype='O'
hashtables which were the target of that fix. Because of
that all
data_version == 2
files are corrupted.This commit fixes the rebuild hashtable logic by actually
looking up the raw data slice for each chunk. Furthermore
called implicitly, rather than it happening silently.
data_version == 2
file it raisesan exception and asks the user to recreate the file.
Fixes #280.