Update error/warning message to give correct instructions #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error message since you cannot directly pass a file name to `VersionedHDF5File`. Internal ticket: PyInf#11354
ArvidJB
added a commit
to ArvidJB/versioned-hdf5
that referenced
this pull request
Nov 7, 2023
When hashing `dtype=object` arrays we need to include the
length of the individual strings, otherwise arrays with
identical contents after concatenating all elements
hash to the same value:
```
>>> import h5py
... import versioned_hdf5
... import numpy as np
...
... path = "temp.h5"
...
... with h5py.File(path, mode="w") as f:
... file = versioned_hdf5.VersionedHDF5File(f)
... with file.stage_version("r0") as group:
... group.create_dataset(
... "values", shape=(2,), dtype=h5py.string_dtype(encoding='ascii'), data=np.array([b"a", b"bc"], dtype=object),
... maxshape=(None,), chunks=(10000,), compression="gzip", shuffle=False,
... )
... with file.stage_version("r1") as group:
... group.create_dataset(
... "values", shape=(2,), dtype=h5py.string_dtype(encoding='ascii'), data=np.array([b"ab", b"c"], dtype=object),
... maxshape=(None,), chunks=(10000,), compression="gzip", shuffle=False,
... )
...
... with h5py.File(path, mode="r") as f:
... file = versioned_hdf5.VersionedHDF5File(f)
... for i in range(2):
... print(file[f"r{i}"]["values"][:])
...
[b'a' b'bc']
[b'a' b'bc']
```
By including the length of each string as part of the hash the hashes
will now be unique.
This also includes the changes in deshaw#287
and supersedes that PR.
Fixes deshaw#288
peytondmurray
pushed a commit
that referenced
this pull request
Nov 9, 2023
* Include string length when hashing
When hashing `dtype=object` arrays we need to include the
length of the individual strings, otherwise arrays with
identical contents after concatenating all elements
hash to the same value:
```
>>> import h5py
... import versioned_hdf5
... import numpy as np
...
... path = "temp.h5"
...
... with h5py.File(path, mode="w") as f:
... file = versioned_hdf5.VersionedHDF5File(f)
... with file.stage_version("r0") as group:
... group.create_dataset(
... "values", shape=(2,), dtype=h5py.string_dtype(encoding='ascii'), data=np.array([b"a", b"bc"], dtype=object),
... maxshape=(None,), chunks=(10000,), compression="gzip", shuffle=False,
... )
... with file.stage_version("r1") as group:
... group.create_dataset(
... "values", shape=(2,), dtype=h5py.string_dtype(encoding='ascii'), data=np.array([b"ab", b"c"], dtype=object),
... maxshape=(None,), chunks=(10000,), compression="gzip", shuffle=False,
... )
...
... with h5py.File(path, mode="r") as f:
... file = versioned_hdf5.VersionedHDF5File(f)
... for i in range(2):
... print(file[f"r{i}"]["values"][:])
...
[b'a' b'bc']
[b'a' b'bc']
```
By including the length of each string as part of the hash the hashes
will now be unique.
This also includes the changes in #287
and supersedes that PR.
Fixes #288
* Update comment
|
Merged as part of #288 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error message since you cannot directly pass a file name to
VersionedHDF5File.Internal ticket: PyInf#11354