Add diff API #293
Merged
Add diff API #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds an API for calculating the diff between two versions of a dataset; closes #264.
Tests are provided which check
An intersphinx mapping was added for numpy as well in order to handle docstrings for this new function.
Testing
I wrote a small benchmark to check how fast this implementation was. In the benchmark, I compared calling
get_diffto iterating over two versions of a dataset and comparing the chunks usingnp.assert_equal. For very small datasets, direct comparison with numpy is fastest. As datasets get larger, directly iterating over the data becomes impractical:@rahasurana Can you take a look at this?