Fix nondefault compression handling #358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes compression handling for nondefault compression types, closes #321 and partially addresses #331. Additionally if
recreate_dataset
is called, we now log a warning message if compression is enabled for the dataset; this is becauseh5py
stores compression settings inDataset._filters
, and we have no way of distinguishing these from other filters that may be present in the file.In practice I think this is an unusual use case, but we now emit a warning if this does happen.
If an invalid compression setting is requested in
write_dataset
, a more informative error message is displayed with a listing of all detected compression settings.