Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert fill_hyperspace #380

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Revert fill_hyperspace #380

merged 2 commits into from
Oct 15, 2024

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Oct 15, 2024

We have discovered that the design of #370 is not viable due to performance showstoppers in libhdf5.
This PR reverts #371, as none of its functionality is needed anymore.

@crusaderky crusaderky self-assigned this Oct 15, 2024
@crusaderky
Copy link
Collaborator Author

pre-commit fix in #381

Copy link
Collaborator

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@peytondmurray peytondmurray merged commit 92d87e1 into deshaw:master Oct 15, 2024
7 of 8 checks passed
@crusaderky crusaderky deleted the hyperspace branch October 15, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants