Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always call H5SClose #383

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Always call H5SClose #383

merged 3 commits into from
Oct 15, 2024

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Oct 15, 2024 •
edited
Loading

Add H5SClose calls to build_data_dict() to release libhdf5 resources after they've been acquired.

@crusaderky
Copy link
Collaborator Author

@peytondmurray could you test this and see if it solves your problem?

@crusaderky crusaderky self-assigned this Oct 15, 2024
peytondmurray
peytondmurray approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@peytondmurray peytondmurray left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and I think this is it. Not sure how you found this, but I'm grateful! There's nothing in the docs for e.g. H5Pget_virtual_vspace, but I guess if you're someone who is used to using dataspace identifiers via the HDF5 C API you probably know this already?

@peytondmurray peytondmurray merged commit fc7d4a3 into deshaw:master Oct 15, 2024
8 checks passed
@crusaderky
Copy link
Collaborator Author

Tested and I think this is it. Not sure how you found this, but I'm grateful! There's nothing in the docs for e.g. H5Pget_virtual_vspace, but I guess if you're someone who is used to using dataspace identifiers via the HDF5 C API you probably know this already?

I guess it's somewhere towards the beginning of the libhdf5 documentation, as a general note. Also something that comes more natural to C programmers than to us who are used to self-cleaning objects.

@crusaderky crusaderky deleted the h5sclose branch October 15, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peytondmurray peytondmurray peytondmurray approved these changes

Assignees

@crusaderky crusaderky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slicetools platform-specific error could not get virtual filename
2 participants
@crusaderky @peytondmurray