[InMemoryDataset redesign] ix_with_slices, format_ndindex #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
crusaderky
force-pushed
the
ix_with_slices
branch
from
d4a6c7b
to
b990862
Compare
This was referenced Oct 20, 2024
peytondmurray
approved these changes
Oct 21, 2024
| return np.ix_(*idx2) | ||
|
|
||
|
|
||
| def format_ndindex(idx: Any) -> str: |
There was a problem hiding this comment.
Looks good. Maybe ndindex itself would benefit from implementing something similar for its objects. If that happens, we could just return str(ndindex(idx)) here. Anyway for now this looks good.
| return a.astype(dtype) | ||
|
|
||
|
|
||
| def ix_with_slices(*idx: Any, shape: tuple[int, ...]) -> tuple: |
There was a problem hiding this comment.
Oh, this is really cool. With this you can more elegantly select hyperrectangles of n-dim arrays. Nice!
|
Both of these things could definitely live in ndindex itself, although it's understandable if you just want to put them here first since ndindex may have more stringent requirements. |
crusaderky
force-pushed
the
ix_with_slices
branch
from
b990862
to
c90a929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new general purpose functions