Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean __init__.py #383

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Clean __init__.py #383

merged 2 commits into from
Mar 28, 2024

Conversation

robertdstein
Copy link
Member

This PR removes a couple of imports from the base nuztf code __init__.py fle. That might seem pointless, but it means that the gcn parsing can be imported without touching/importing any of the ampel-interfacing code. That is important because ampel needs pydantic v1, and winter api code needs pydantic v2. I hope Ampel will soon be bumped to use pydantic v2 as well.

@coveralls
Copy link

Coverage Status

coverage: 70.301% (-0.02%) from 70.324%
when pulling 0fda4ed on tester
into 0787c7b on main.

@robertdstein robertdstein merged commit 42307f7 into main Mar 28, 2024
8 of 10 checks passed
@robertdstein robertdstein deleted the tester branch March 28, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants